Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name conflict if tracked model has "instance" field #634

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shemigon
Copy link

@shemigon shemigon commented Oct 19, 2024

Problem

If a tracked model has the instance field, creating a instance of the model throws

TypeError: Model.__init__() got multiple values for argument 'instance'

See issue #633

Solution

Removed instance argument from the new model init method and used args[0] instead.

Commandments

  • Write PEP8 compliant code.
  • Cover it with tests.
  • Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
  • Pay attention to backward compatibility, or if it breaks it, explain why.
  • Update documentation (if relevant).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant