Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shipping address to be sent to Paypal #132

Closed
wants to merge 2 commits into from

Conversation

dankingston
Copy link

No description provided.

@devkral
Copy link
Contributor

devkral commented Oct 6, 2017

The problem: how is get_shipping_address_for_paypal() implemented?

I think there would be a cleaner solution if you provide a provider method. In best case we could merge our efforts:
#149

@BenSturmfels
Copy link
Contributor

This pull request is missing the code for get_shipping_address_for_paypal() and appears to be abandoned. I'd suggest closing.

@WhyNotHugo
Copy link
Member

In case interest in this re-arises, the shipping address should ideally be a dataclass, to make it obvious how it should be implemented and facilitate type checking.

@WhyNotHugo WhyNotHugo closed this Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants