make status_changed signal more robust #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 79.13% 79.18% +0.05%
==========================================
Files 27 27
Lines 1649 1653 +4
Branches 190 192 +2
==========================================
+ Hits 1305 1309 +4
Misses 245 245
Partials 99 99
Continue to review full report at Codecov.
|
|
integrated in #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using send, use send_robust and check for errors in the return values. These are logged with logging level critical so they are clearly visible.
If you have a bank facing api it can be really annoying if a signal handler crashes because you don't see the error (in debug mode) and a small unimportant handler can corrupt a transaction. This fixes the issue.