Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Paydirekt provider #155

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Oct 13, 2017

This adds a backend for paydirekt.
It depends on some other pullrequests of mine:
#148 #149

Sry for the long commit history. I required the backend for a project.

…s (allows much more freedom) and adjust all providers for the change

use create_test_payment for tests, TestPayment is now a Mock
use unittest mocks when python3
@codecov-io
Copy link

codecov-io commented Oct 17, 2017

Codecov Report

Merging #155 into master will increase coverage by 0.08%.
The diff coverage is 79.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   79.13%   79.22%   +0.08%     
==========================================
  Files          27       29       +2     
  Lines        1649     1993     +344     
  Branches      190      234      +44     
==========================================
+ Hits         1305     1579     +274     
- Misses        245      292      +47     
- Partials       99      122      +23
Impacted Files Coverage Δ
payments/sofort/__init__.py 87.71% <ø> (-1.17%) ⬇️
payments/paypal/__init__.py 84.58% <100%> (ø) ⬆️
payments/core.py 83.07% <100%> (-4.62%) ⬇️
payments/authorizenet/__init__.py 79.54% <100%> (ø) ⬆️
payments/stripe/forms.py 96.92% <100%> (+0.09%) ⬆️
payments/braintree/forms.py 93.1% <100%> (+0.51%) ⬆️
payments/stripe/__init__.py 60% <100%> (ø) ⬆️
payments/dummy/__init__.py 81.13% <100%> (-5.67%) ⬇️
payments/cybersource/__init__.py 66.56% <100%> (+0.1%) ⬆️
payments/sagepay/__init__.py 90.76% <66.66%> (+2.05%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c93aa...823028e. Read the comment docs.

@patrys
Copy link
Contributor

patrys commented Oct 17, 2017

Thank you for this contribution. I think we'd prefer for new payment providers to live in their own packages. In fact we've discussed splitting the current main package.

Please take a look at https://github.com/esistgut/django-payments-bnlepos for an externally-maintained payment provider.

@devkral
Copy link
Contributor Author

devkral commented Oct 18, 2017

good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants