Bugfix for Cybersource. Wrong exception was except #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix and added documentation about a feature Optional parameters payment.attrs.fingerprint_session_id payment.attrs.merchant_defined_data were essentially required otherwise an error was thrown. Was caused by the wrong exception being captured
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 80.02% 80.11% +0.09%
==========================================
Files 29 29
Lines 1857 1861 +4
Branches 270 270
==========================================
+ Hits 1486 1491 +5
Misses 259 259
+ Partials 112 111 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
There's a few unrelated errors in CI. I'll try to address those, but I think this PR looks good. |
|
Great, thank you. I appreciate your work supporting this package, I find it
valuable.
…On Tue, Aug 9, 2022 at 9:03 AM Hugo ***@***.***> wrote:
There's a few unrelated errors in CI. I'll try to address those, but I
think this PR looks good.
—
Reply to this email directly, view it on GitHub
<#324 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCSSKW4MDN45ATH4NQ5RODVYINFBANCNFSM55XGZWOQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Merged in ea85be8. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix and added documentation about a feature
Optional parameters
error was thrown if the parameters above were not included, but that doesn't appear to be the intended design
Was caused by the wrong exception being captured
Issue #323