PayPal: Perform full refund if amount=None #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekholy24
force-pushed
the
paypal_full_refund
branch
2 times, most recently
from
38f5a69
to
95969ce
Compare
WhyNotHugo
reviewed
Jun 11, 2024
WhyNotHugo
reviewed
Jun 12, 2024
|
Can you rebase and fix merge conflicts? (sorry, the permissions on this repo won't allow me to just perform the merge myself) |
WhyNotHugo
approved these changes
Jun 12, 2024
radekholy24
force-pushed
the
paypal_full_refund
branch
from
95969ce
to
e5f3d96
Compare
|
@WhyNotHugo, no problem. Rebased. |
|
Needs to be rebased due to #410 |
radekholy24
force-pushed
the
paypal_full_refund
branch
from
e5f3d96
to
b456e33
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
- Coverage 78.42% 78.41% -0.01%
==========================================
Files 29 29
Lines 1979 1983 +4
Branches 244 244
==========================================
+ Hits 1552 1555 +3
- Misses 310 311 +1
Partials 117 117 ☔ View full report in Codecov by Sentry. |
|
Sure. Rebased, @WhyNotHugo |
|
Thanks! |
Goury
pushed a commit
to Goury/django-payments
that referenced
this pull request
Jul 6, 2024
Goury
added a commit
to Goury/django-payments
that referenced
this pull request
Jul 6, 2024
fix jazzband#411 Manually following process URL results in a crash
Goury
pushed a commit
to Goury/django-payments
that referenced
this pull request
Jul 6, 2024
Goury
added a commit
to Goury/django-payments
that referenced
this pull request
Jul 6, 2024
fix jazzband#411 Manually following process URL results in a crash
Goury
pushed a commit
to Goury/django-payments
that referenced
this pull request
Jul 6, 2024
WhyNotHugo
pushed a commit
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PayPal does support refunding without an amount specified and django-payment's API as well, it makes sense to me.
The benefit is that for various reasons the local copy of the payment (
BasePayment.captured_amount) may get easily desynchronized with the payment gateway (e.g. bugs like this #309 (see #412)). This performs the full refund regardless of theBasePayment.captured_amount.This change will have an effect only if #401 gets fixed (see #410) but it won't hurt otherwise too.
Feel free to request any necessary changes 🙏