Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category to apns-async calls #758

Closed
wants to merge 1 commit into from

Conversation

aaronn
Copy link

@aaronn aaronn commented Jan 18, 2025

APNS has the concept of a category and this was lost in the addition of the async version of this package with the addition of apns-async. This re-adds category support.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.43%. Comparing base (44977b1) to head (3729071).
Report is 52 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
+ Coverage   70.39%   72.43%   +2.04%     
==========================================
  Files          27       29       +2     
  Lines        1101     1237     +136     
  Branches      180      204      +24     
==========================================
+ Hits          775      896     +121     
- Misses        288      298      +10     
- Partials       38       43       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronn
Copy link
Author

aaronn commented Jan 21, 2025

This doesn't work

@aaronn aaronn closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant