Add Python 3.12 to test matrix and add classifier #689
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
=========================================
+ Coverage 63.3% 90.3% +27.1%
=========================================
Files 43 22 -21
Lines 3215 1346 -1869
Branches 244 0 -244
=========================================
- Hits 2034 1215 -819
+ Misses 1164 131 -1033
+ Partials 17 0 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
foarsitter
force-pushed
the
py312
branch
4 times, most recently
from
2387901
to
9f5f8c9
Compare
.github/workflows/ci.yml
Outdated
| @@ -90,7 +95,7 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| python -m pip install --upgrade "tox<4" tox-gh-actions | |||
| python -m pip install --upgrade "tox<4" tox-gh-actions setuptools | |||
There was a problem hiding this comment.
setuptools is no longer bundled with Python 3.12
setup.cfg
Outdated
| @@ -122,7 +125,7 @@ deps = | |||
| dj42: Django>=4.2,<5.0 | |||
| djmain: https://github.com/django/django/archive/main.tar.gz | |||
| msgpack>=0.6.0 | |||
| pytest | |||
| pytest<7.0.0 | |||
|
Seems like we need to update pytest to > 7.0 in order to get the tests working for Python 3.12. My initial statement was a little to harsh. |
|
I am afraid it is a bit early to work add python3.12, it might fail until redis/redis-py#2979 In the meantime #697 will add support for pytest>=7 |
|
@WisdomPill We have an issue with async SSL in 3.12. But this should release in the 5.x final. |
|
thanks for the heads up @chayim! 😉 |
|
We need to wait for the 5.1 release of redis-py before this can be merged, right? |
Everything seems fine for Python 3.12 and no change are required.