Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for EOL Django versions (3.2, 4.0, 4.1) #528

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Drop support for EOL Django versions (3.2, 4.0, 4.1) #528

merged 1 commit into from
Nov 19, 2024

Conversation

ulgens
Copy link
Member

@ulgens ulgens commented Nov 16, 2024

No description provided.

@ulgens ulgens requested a review from clintonb November 16, 2024 11:50
@ulgens ulgens self-assigned this Nov 16, 2024
clintonb
clintonb reviewed Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@clintonb clintonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the commit hook, and let’s discuss separately. I’m unclear on the implications of this, and don’t want to unnecessarily burden folks just trying to fix bugs.

dancergraham
dancergraham reviewed Nov 16, 2024
View reviewed changes
Copy link
Contributor

@dancergraham dancergraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour - note that based on my reading of jazzband guidelines this does not need a major version bump.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@ulgens ulgens requested a review from clintonb November 16, 2024 15:19
@ulgens ulgens merged commit 2a932a0 into master Nov 19, 2024
11 checks passed
@ulgens ulgens deleted the drop_eol_django branch November 19, 2024 23:38
@ulgens ulgens mentioned this pull request Nov 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancergraham dancergraham dancergraham left review comments

@clintonb clintonb clintonb approved these changes

Assignees

@ulgens ulgens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulgens @clintonb @dancergraham