-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement show_dataframe #177
base: master
Are you sure you want to change the base?
Conversation
Finally fixed colab issues. Here is an example notebook. Below you can see a screenshot from the notebook. |
Beautiful!!
|
Yes, the whole dataset is loaded into the browser. Locally, this works for me until around ~50k rows, then it starts to get really slow to load. As soon as it is loaded, the search is really quick. I think that changing (i.e. only loading parts and dynamically loading more etc.) would be a huge amount of work that's probably out-of-scope at this point; but it might be interesting to revisit this later. I think that for many users it's still already very useful (as long as either the dataset is not very big or the machine is powerful, everything works great).
That is by default enabled for datatables (see here), and it also works locally. It does not work in colab, not sure why. It's difficult to see why/how some HTML rendering fails in colab/jupyter 🦡
Again, that's also only a colab problem and we're not sure how to solve this without a huge amount of work 😞
I agree that a custom accessor might be confusing; I think we could call it
Again, that's also quite difficult as far as I can see.
Yes, very. Everything runs locally and we're basically only serving one HTML file with the datatable. ** Summary **: We could probably spend a lot of time making this better for big data / ..., but that's probably out-of-scope for texthero; we think that the simple, relatively lightweight implementation here is good and other, more dynamic stuff would take lots and lots of effort spent on this one function. That's why we're a little hesitant to do that - we think it's already quite useful for most users, and still quite simple. Making it perfect would be interesting and fun, but also hard and time-consuming. |
we just went through this PR again and from our side, it is ready for review 🍾 🍺 🍻 |
TODO
|
This new function in the visualization module allows users to scroll through a DataFrame and search it. We believe this is much nicer than the built-in pandas printing and could be a heavily used function 🥈 . See this notebook for an example.
Internally, this works by creating an HTML DataTable. The relevant files are in the new texthero subfolder visualization-server that implements an extremely light-weight way to create our visualizations. It's adopted from pyLDAvis and refactored/simplified by us. This folder can also be used for further texthero visualization functions in the future.
Note: travis/setup changed because of #171 . This is branched straight from master.
EDIT:
still working on support for online Jupyter Notebooks (e.g. Colab)✔️