Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows specific int comparison error #120

Open
Caleb-Carr opened this issue Sep 16, 2022 · 1 comment
Open

Windows specific int comparison error #120

Caleb-Carr opened this issue Sep 16, 2022 · 1 comment

Comments

@Caleb-Carr
Copy link

Caleb-Carr commented Sep 16, 2022

In pdb_utils.py, the following line in def reassign_b_factor raises an error when run on a windows machine because windows handles int differently than unix systems

if df[site_col].dtype != int:
        raise ValueError("function currently requires `site_col` to be int")

This is explained in the following post: https://stackoverflow.com/questions/64901822/why-do-pandas-integer-dtypes-not-behave-the-same-on-unix-and-windows

@jbloom
Copy link
Member

jbloom commented Sep 16, 2022

@Caleb-Carr, you can add a pull request to fix this (and any other Windows specific issues) if you want. Otherwise I am probably not going to do it though as only use Linux / Mac and that is all we are using for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants