Fix venmo transactions for crypto-holding accounts #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@inderpreet99, we don't normally introduce changes that will ignore transactions. Users can find this surprising. Would you be interested in upgrading this PR to actually handle the crypto transactions? Or perhaps you can provide a sample CSV file (appropriately anonymized)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer csv downloads include crypto details as well "Available beginning" and "Available ending" balances. This PR seeks to ignore those rows.
Why? The crypto transactions do not follow the csv format specified for regular Venmo transactions (like payment or standard transfers). Handling these transactions will require special parsing to process.