do not decode result_string returned by set_password #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field testing ofset_password()
with latest MIT and real AD introduced a potential decryption error ofresult_string
which comes from server in encrypted format.The decryption works fine with k5test.
The root cause of this problem remains unclear (may be a native library, cipher negotiation issue, etc).
Until it is resolved, the Python code at least should not crash.
Thus I propose to not decode the string and leave as is.
UPD:
The
result_string
may be a binary encoded structure in proprietary format returned asresult_string
. It can be decoded and i18n'ized by client, likekpasswd(1)
does.K5test
result_string
is always a UTF-8 string which is also possible.Current implementation leaves decoding to the client so
result_string
is returned as a raw byte sequence.