Improve performance of publication #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acquiring a logger inside a loop causes repeated stack traversals. The log event generally does not need to have a category object, so we populate it lazily instead. Eliminate repeated construction of filter objects, and inline the filter checking logic.
|
@dmlloyd Can we merge this PR and tag version 1.3.1? We have to include it in the upcoming EAP 7.4.18. Thanks! |
|
WDYT @jamezp? |
jamezp
approved these changes
May 21, 2024
|
Sorry, I completely spaced this. It's merged, do we need a release too? |
Yes please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acquiring a logger inside a loop causes repeated stack traversals. The log event generally does not need to have a category object, so we populate it lazily instead. Eliminate repeated construction of filter objects, and inline the filter checking logic.