Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated instance_id utility function #290

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Conversation

jbusecke
Copy link
Owner

@jbusecke jbusecke commented Apr 6, 2023

  • Deprecation warning on utils.cmip6_dataset_id + reminder issue to remove in next major release
  • Add documentation with official sources about ESGF id structure (include member_id/instance_id discussion). Check back into issues at pangeo-forge-esgf. Which repo should hold this info?
  • Kwarg input that switches between printing missing facets as none (default) and dropping them from the combined string (this should then be used in combine_datasets for the new dict key generation.

@jbusecke
Copy link
Owner Author

jbusecke commented Jun 9, 2023

Flake8 formatting issue was solved with this. Adding r"..." did the trick

@jbusecke jbusecke marked this pull request as ready for review June 25, 2024 03:23
@jbusecke
Copy link
Owner Author

I need to stash this for later. Last action was to put a blank raise in the deprecated iid function to facilitate refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant