Merge pull request #4415 from jbx-protocol/revert-4412-dev

Revert "Release: 2024-07-30"

.github/workflows/ci-run.yml

@@ -9,11 +9,9 @@ on:
       - synchronize
     branches:
       - main
-      - dev
   push:
     branches:
       - main
-      - dev
 
   # manual trigger from Github UI - Action tab
   workflow_dispatch:

.github/workflows/sepolia.yml

@@ -3,7 +3,7 @@ name: Deploy Migrations to Sepolia
 on:
   push:
     branches:
-      - dev
+      - main
   workflow_dispatch:
 
 jobs:

package.json

@@ -109,8 +109,8 @@
     "graphql": "^16.8.1",
     "he": "^1.2.0",
     "jsonwebtoken": "^9.0.0",
-    "juice-sdk-core": "^10.0.3-alpha",
-    "juice-sdk-react": "^10.0.1-alpha",
+    "juice-sdk-core": "^9.1.3-alpha",
+    "juice-sdk-react": "^9.2.3-alpha",
     "juicebox-metadata-helper": "0.1.7",
     "less": "4.1.2",
     "lodash": "^4.17.21",

src/components/ActivityList.tsx

@@ -12,12 +12,12 @@ import {
 import { useMemo, useState } from 'react'
 import { AnyProjectEvent } from './activityEventElems/AnyProjectEvent'
 
-export interface ActivityOption {
+interface ActivityOption {
   label: string
   value: ProjectEventFilter
 }
 
-export const ALL_OPT = (): ActivityOption => ({ label: t`All activity`, value: 'all' })
+const ALL_OPT = (): ActivityOption => ({ label: t`All activity`, value: 'all' })
 
 const PV1_OPTS = (): ActivityOption[] => [
   ALL_OPT(),

src/packages/v2v3/components/shared/PayoutsTable/ConvertAmountsModal.tsx → src/components/Create/components/pages/PayoutsPage/components/ConvertAmountsModal.tsx

@@ -2,12 +2,12 @@ import { t, Trans } from '@lingui/macro'
 import { Divider, Modal } from 'antd'
 import CurrencySwitch from 'components/currency/CurrencySwitch'
 import EthereumAddress from 'components/EthereumAddress'
-import { ExternalLinkWithIcon } from 'components/ExternalLinkWithIcon'
 import FormattedNumberInput from 'components/inputs/FormattedNumberInput'
 import { Parenthesis } from 'components/Parenthesis'
+import { Split } from 'models/splits'
 import V2V3ProjectHandleLink from 'packages/v2v3/components/shared/V2V3ProjectHandleLink'
+import { ExternalLinkWithIcon } from 'packages/v2v3/components/V2V3Project/ProjectDashboard/components/ui/ExternalLinkWithIcon'
 import { V2V3CurrencyOption } from 'packages/v2v3/models/currencyOption'
-import { Split } from 'packages/v2v3/models/splits'
 import {
   V2V3_CURRENCY_ETH,
   V2V3_CURRENCY_USD,
@@ -18,8 +18,6 @@ import {
 } from 'packages/v2v3/utils/distributions'
 import { formatCurrencyAmount } from 'packages/v2v3/utils/formatCurrencyAmount'
 import { SPLITS_TOTAL_PERCENT } from 'packages/v2v3/utils/math'
-import { allocationToSplit, splitToAllocation } from 'packages/v2v3/utils/splitToAllocation'
-import { isProjectSplit } from 'packages/v2v3/utils/v2v3Splits'
 import { ReactNode, useCallback, useMemo, useState } from 'react'
 import {
   ReduxDistributionLimit,
@@ -28,6 +26,8 @@ import {
 import { parseWad } from 'utils/format/formatNumber'
 import { formatPercent } from 'utils/format/formatPercent'
 import { helpPagePath } from 'utils/routes'
+import { isProjectSplit } from 'utils/splits'
+import { allocationToSplit, splitToAllocation } from 'utils/splitToAllocation'
 
 export const ConvertAmountsModal = ({
   open,

src/components/Create/components/pages/PayoutsPage/components/CreateFlowPayoutsTable.tsx

@@ -1,16 +1,16 @@
 import { Form } from 'antd'
 import { CURRENCY_METADATA, CurrencyName } from 'constants/currency'
+import { Split } from 'models/splits'
 import { PayoutsTable } from 'packages/v2v3/components/shared/PayoutsTable/PayoutsTable'
-import { Split } from 'packages/v2v3/models/splits'
 import {
   V2V3CurrencyName,
   getV2V3CurrencyOption,
 } from 'packages/v2v3/utils/currency'
 import { MAX_DISTRIBUTION_LIMIT } from 'packages/v2v3/utils/math'
-import { allocationToSplit, splitToAllocation } from 'packages/v2v3/utils/splitToAllocation'
 import { ReactNode } from 'react'
 import { useEditingDistributionLimit } from 'redux/hooks/useEditingDistributionLimit'
 import { fromWad, parseWad } from 'utils/format/formatNumber'
+import { allocationToSplit, splitToAllocation } from 'utils/splitToAllocation'
 import { usePayoutsForm } from '../hooks/usePayoutsForm'
 
 const DEFAULT_CURRENCY_NAME = CURRENCY_METADATA.ETH.name

src/components/Create/components/pages/PayoutsPage/components/TreasuryOptionsRadio.tsx

@@ -3,16 +3,16 @@ import { RadioGroup } from '@headlessui/react'
 import { t } from '@lingui/macro'
 import { Callout } from 'components/Callout/Callout'
 import { DeleteConfirmationModal } from 'components/modals/DeleteConfirmationModal'
-import { SwitchToUnlimitedModal } from 'components/PayoutsTable/SwitchToUnlimitedModal'
 import { useModal } from 'hooks/useModal'
 import { TreasurySelection } from 'models/treasurySelection'
-import { ConvertAmountsModal } from 'packages/v2v3/components/shared/PayoutsTable/ConvertAmountsModal'
 import { usePayoutsTable } from 'packages/v2v3/components/shared/PayoutsTable/hooks/usePayoutsTable'
+import { SwitchToUnlimitedModal } from 'packages/v2v3/components/shared/PayoutsTable/modals/SwitchToUnlimitedModal'
 import { useCallback, useEffect, useMemo, useState } from 'react'
 import { useAppSelector } from 'redux/hooks/useAppSelector'
 import { ReduxDistributionLimit } from 'redux/hooks/useEditingDistributionLimit'
 import { fromWad } from 'utils/format/formatNumber'
 import { Icons } from '../../../Icons'
+import { ConvertAmountsModal } from './ConvertAmountsModal'
 import { RadioCard } from './RadioCard'
 
 const treasuryOptions = () => [

src/components/Create/components/pages/PayoutsPage/hooks/usePayoutsForm.ts

@@ -1,11 +1,11 @@
 import { Form } from 'antd'
 import { TreasurySelection } from 'models/treasurySelection'
 import { AllocationSplit } from 'packages/v2v3/components/shared/Allocation/Allocation'
-import { allocationToSplit, splitToAllocation } from 'packages/v2v3/utils/splitToAllocation'
 import { useDebugValue, useEffect, useMemo } from 'react'
 import { useAppDispatch } from 'redux/hooks/useAppDispatch'
 import { useAppSelector } from 'redux/hooks/useAppSelector'
 import { useEditingPayoutSplits } from 'redux/hooks/useEditingPayoutSplits'
+import { allocationToSplit, splitToAllocation } from 'utils/splitToAllocation'
 
 type PayoutsFormProps = Partial<{
   selection: TreasurySelection

src/components/Create/components/pages/ProjectToken/hooks/useProjectTokenForm.ts

@@ -14,13 +14,13 @@ import {
   redemptionRateFrom,
   reservedRateFrom,
 } from 'packages/v2v3/utils/math'
-import { allocationToSplit, splitToAllocation } from 'packages/v2v3/utils/splitToAllocation'
 import { useDebugValue, useEffect, useMemo } from 'react'
 import { useAppDispatch } from 'redux/hooks/useAppDispatch'
 import { useAppSelector } from 'redux/hooks/useAppSelector'
 import { useEditingDistributionLimit } from 'redux/hooks/useEditingDistributionLimit'
 import { useEditingReservedTokensSplits } from 'redux/hooks/useEditingReservedTokensSplits'
 import { editingV2ProjectActions } from 'redux/slices/editingV2Project'
+import { allocationToSplit, splitToAllocation } from 'utils/splitToAllocation'
 import { useFormDispatchWatch } from '../../hooks/useFormDispatchWatch'
 
 export type ProjectTokensFormProps = Partial<{

src/components/Create/components/pages/ReviewDeploy/ReviewDeployPage.tsx

@@ -7,10 +7,10 @@ import ExternalLink from 'components/ExternalLink'
 import TransactionModal from 'components/modals/TransactionModal'
 import { TERMS_OF_SERVICE_URL } from 'constants/links'
 import { useWallet } from 'hooks/Wallet'
-import { emitConfirmationDeletionModal } from 'hooks/emitConfirmationDeletionModal'
 import useMobile from 'hooks/useMobile'
 import { useModal } from 'hooks/useModal'
 import { useRouter } from 'next/router'
+import { emitConfirmationDeletionModal } from 'packages/v2v3/components/V2V3Project/ProjectDashboard/utils/modals'
 import { useCallback, useContext, useEffect, useMemo, useState } from 'react'
 import { useDispatch } from 'react-redux'
 import { useAppSelector } from 'redux/hooks/useAppSelector'

src/components/Create/components/pages/ReviewDeploy/components/FundingConfigurationReview/hooks/useFundingConfigurationReview.ts

@@ -3,13 +3,13 @@ import { useAvailablePayoutsSelections } from 'components/Create/components/page
 import { formatFundingCycleDuration } from 'components/Create/utils/formatFundingCycleDuration'
 import moment from 'moment'
 import { AllocationSplit } from 'packages/v2v3/components/shared/Allocation/Allocation'
-import { allocationToSplit, splitToAllocation } from 'packages/v2v3/utils/splitToAllocation'
 import { useCallback, useMemo } from 'react'
 import { useAppSelector } from 'redux/hooks/useAppSelector'
 import { useEditingDistributionLimit } from 'redux/hooks/useEditingDistributionLimit'
 import { useEditingPayoutSplits } from 'redux/hooks/useEditingPayoutSplits'
 import { DEFAULT_MUST_START_AT_OR_AFTER } from 'redux/slices/editingV2Project'
 import { formatFundingTarget } from 'utils/format/formatFundingTarget'
+import { allocationToSplit, splitToAllocation } from 'utils/splitToAllocation'
 
 export const useFundingConfigurationReview = () => {
   const { fundingCycleData, payoutsSelection, mustStartAtOrAfter } =

src/components/Create/components/pages/ReviewDeploy/components/ProjectTokenReview/hooks/useProjectTokenReview.ts

@@ -1,9 +1,9 @@
 import { AllocationSplit } from 'packages/v2v3/components/shared/Allocation/Allocation'
-import { allocationToSplit, splitToAllocation } from 'packages/v2v3/utils/splitToAllocation'
 import { useCallback, useMemo } from 'react'
 import { useAppSelector } from 'redux/hooks/useAppSelector'
 import { useEditingReservedTokensSplits } from 'redux/hooks/useEditingReservedTokensSplits'
 import { formatEnabled, formatPaused } from 'utils/format/formatBoolean'
+import { allocationToSplit, splitToAllocation } from 'utils/splitToAllocation'
 
 export const useProjectTokenReview = () => {
   const {

src/components/Create/utils/projectTokenSettingsToReduxFormat.ts

@@ -4,8 +4,8 @@ import {
   redemptionRateFrom,
   reservedRateFrom,
 } from 'packages/v2v3/utils/math'
-import { allocationToSplit } from 'packages/v2v3/utils/splitToAllocation'
 import { EMPTY_RESERVED_TOKENS_GROUPED_SPLITS } from 'redux/slices/editingV2Project'
+import { allocationToSplit } from 'utils/splitToAllocation'
 import { ProjectTokensFormProps } from '../components/pages/ProjectToken/hooks/useProjectTokenForm'
 
 export const projectTokenSettingsToReduxFormat = (

src/packages/v2v3/components/shared/FeeTooltipLabel.tsx → src/components/FeeTooltipLabel.tsx

@@ -1,14 +1,14 @@
 import { Trans } from '@lingui/macro'
-import ExternalLink from 'components/ExternalLink'
-import TooltipLabel from 'components/TooltipLabel'
-import CurrencySymbol from 'components/currency/CurrencySymbol'
-import ETHAmount from 'components/currency/ETHAmount'
 import { BigNumber } from 'ethers'
 import { V2V3CurrencyOption } from 'packages/v2v3/models/currencyOption'
 import { V2V3_CURRENCY_ETH } from 'packages/v2v3/utils/currency'
 import { amountSubFee, formatFee } from 'packages/v2v3/utils/math'
 import { formatWad } from 'utils/format/formatNumber'
 import { helpPagePath } from 'utils/routes'
+import ExternalLink from './ExternalLink'
+import TooltipLabel from './TooltipLabel'
+import CurrencySymbol from './currency/CurrencySymbol'
+import ETHAmount from './currency/ETHAmount'
 
 export const FeeTooltipLabel = ({
   currency,

src/components/Navbar/components/TransactionList/TransactionsList.tsx

@@ -5,8 +5,8 @@ import BadgeIcon from 'components/BadgeIcon'
 import ExternalLink from 'components/ExternalLink'
 import Loading from 'components/Loading'
 import {
-  TransactionLog,
   TxHistoryContext,
+  timestampForTxLog,
 } from 'contexts/Transaction/TxHistoryContext'
 import { TxStatus } from 'models/transaction'
 import { useContext, useEffect, useMemo, useState } from 'react'
@@ -15,11 +15,6 @@ import { etherscanLink } from 'utils/etherscan'
 import { formatHistoricalDate } from 'utils/format/formatDate'
 import TxStatusIcon from './TxStatusIcon'
 
-// Prefer using tx.timestamp if tx has been mined. Otherwise use createdAt timestamp
-export const timestampForTxLog = (txLog: TransactionLog) => {
-  return txLog.tx?.timestamp ?? txLog.createdAt
-}
-
 export function TransactionsList({
   listClassName,
 }: {

src/packages/v2v3/components/V2V3Project/ProjectDashboard/components/ProjectHeaderStats.tsx → src/components/Project/ProjectHeader/ProjectHeaderStats.tsx

@@ -2,12 +2,12 @@ import { BigNumber } from '@ethersproject/bignumber'
 import { ArrowTrendingUpIcon } from '@heroicons/react/24/outline'
 import { t, Trans } from '@lingui/macro'
 import ETHAmount from 'components/currency/ETHAmount'
-import { ProjectHeaderStat } from 'components/Project/ProjectHeader/ProjectHeaderStat'
 import { TRENDING_WINDOW_DAYS } from 'components/Projects/RankingExplanation'
 import { useProjectPageQueries } from 'packages/v2v3/components/V2V3Project/ProjectDashboard/hooks/useProjectPageQueries'
 import { useV2V3ProjectHeader } from 'packages/v2v3/components/V2V3Project/ProjectDashboard/hooks/useV2V3ProjectHeader'
 import { PropsWithChildren, useCallback } from 'react'
 import { twMerge } from 'tailwind-merge'
+import { ProjectHeaderStat } from './ProjectHeaderStat'
 
 export function ProjectHeaderStats() {
   const { payments, totalVolume, last7DaysPercent } = useV2V3ProjectHeader()

src/components/Project/ProjectTabs/CyclesPayoutsTab/ConfigurationPanel.tsx

@@ -16,9 +16,9 @@ export type ConfigurationPanelTableData = {
 
 type ConfigurationPanelProps = {
   cycle: ConfigurationPanelTableData
-  token: ConfigurationPanelTableData
-  otherRules: ConfigurationPanelTableData 
-  extension: ConfigurationPanelTableData | null 
+  token?: ConfigurationPanelTableData // V4TODO: don't make token optional
+  otherRules?: ConfigurationPanelTableData // V4TODO: don't make otherRules optional
+  extension?: ConfigurationPanelTableData | null // V4TODO: don't make extension optional
 }
 
 export const ConfigurationPanel: React.FC<ConfigurationPanelProps> = ({
@@ -30,8 +30,12 @@ export const ConfigurationPanel: React.FC<ConfigurationPanelProps> = ({
   return (
     <div className="flex flex-col gap-8">
       <ConfigurationTable title={t`Cycle`} data={cycle} />
-      <ConfigurationTable title={t`Token`} data={token} />
-      <ConfigurationTable title={t`Other rules`} data={otherRules} />
+      {token && ( // V4TODO: don't make token optional
+        <ConfigurationTable title={t`Token`} data={token} />
+      )}  
+      {otherRules && ( // V4TODO: don't make otherRules optional
+        <ConfigurationTable title={t`Other rules`} data={otherRules} />
+      )}
       {extension && (
         <ConfigurationTable title={t`Extension`} data={extension} />
       )}

src/components/ProjectSafeDashboard/juiceboxTransactions/reconfigureFundingCyclesOf/ReconfigurationRichPreview.tsx

@@ -7,8 +7,8 @@ import FundingCycleDetails from 'packages/v2v3/components/V2V3Project/V2V3Fundin
 import { V2V3ProjectContext } from 'packages/v2v3/contexts/Project/V2V3ProjectContext'
 import { deriveNextIssuanceRate } from 'packages/v2v3/utils/fundingCycle'
 import { formatReservedRate } from 'packages/v2v3/utils/math'
-import { toSplit } from 'packages/v2v3/utils/v2v3Splits'
 import { useContext } from 'react'
+import { toSplit } from 'utils/splits'
 import { LinkToSafeButton } from '../../LinkToSafeButton'
 import { useTransactionJBController } from './hooks/useTransactionJBController'
 

src/components/VolumeChart/hooks/useProjectTimeline.ts

@@ -67,24 +67,16 @@ export function useProjectTimeline({
     return { blocks, timestamps }
   }, [blockData])
 
-  const { data: v1v2v3QueryResult, loading: isLoadingQuery } = useProjectTlQuery({
+  const { data: queryResult, loading: isLoadingQuery } = useProjectTlQuery({
     client,
     variables: {
       id: blocks ? getSubgraphIdForProject(pv, projectId) : '',
       ...blocks,
     },
   })
-  // TODO: const { data: v4QueryResult } = useSubgraphQuery(ProjectTlDocument, {
-  //   where: {
-  //     projectId,
-  //   },
-  // })
 
   const points = useMemo(() => {
-    // TODO: if (!(v1v2v3QueryResult || v4QueryResult) || !timestamps) return
-    if (!v1v2v3QueryResult || !timestamps) return
-    // TODO: const queryResult = pv === PV_V4 ? v4QueryResult : v1v2v3QueryResult
-    const queryResult = v1v2v3QueryResult
+    if (!queryResult || !timestamps) return
 
     const points: ProjectTimelinePoint[] = []
 
@@ -102,7 +94,7 @@ export function useProjectTimeline({
     }
 
     return points
-  }, [timestamps, v1v2v3QueryResult])
+  }, [timestamps, queryResult])
 
   return {
     points,

src/components/formItems/ProjectDiscord.tsx

@@ -14,7 +14,7 @@ export default function ProjectDiscord({
       label={hideLabel ? undefined : t`Discord link`}
       {...formItemProps}
     >
-      <Input type="text" autoComplete="off" prefix="https://" />
+      <Input type="url" autoComplete="off" prefix="https://" />
     </Form.Item>
   )
 }

src/components/formItems/ProjectTelegram.tsx

@@ -14,7 +14,7 @@ export default function ProjectTelegam({
       label={hideLabel ? undefined : t`Telegram link`}
       {...formItemProps}
     >
-      <Input type="text" autoComplete="off" prefix="https://" />
+      <Input type="url" autoComplete="off" prefix="https://" />
     </Form.Item>
   )
 }

src/components/formItems/formHelpers.tsx

@@ -2,7 +2,7 @@ import { isAddress } from 'ethers/lib/utils'
 import { PayoutMod } from 'packages/v1/models/mods'
 import { permyriadToPercent } from 'utils/format/formatNumber'
 
-import { Split } from 'packages/v2v3/models/splits'
+import { Split } from 'models/splits'
 import { isEqualAddress, isZeroAddress } from 'utils/address'
 import { percentToPermyriad } from 'utils/format/formatNumber'
 

src/constants/splits.ts

@@ -1,4 +1,4 @@
-import { ETHPayoutSplitGroup, ReservedTokensSplitGroup } from 'packages/v2v3/models/splits'
+import { ETHPayoutSplitGroup, ReservedTokensSplitGroup } from 'models/splits'
 
 export const ETH_PAYOUT_SPLIT_GROUP: ETHPayoutSplitGroup = 1
 export const RESERVED_TOKEN_SPLIT_GROUP: ReservedTokensSplitGroup = 2

src/contexts/Transaction/EthersTxHistoryProvider.tsx

@@ -1,8 +1,7 @@
 import { readProvider } from 'constants/readProvider'
-import { TxStatus } from 'models/transaction'
+import { TransactionLog, TxStatus } from 'models/transaction'
 import { ReactNode, useEffect } from 'react'
-import { Hash } from 'viem'
-import { TransactionLog, TxHistoryContext } from './TxHistoryContext'
+import { TxHistoryContext } from './TxHistoryContext'
 import { useTransactions } from './useTransactions'
 
 const nowSeconds = () => Math.round(new Date().valueOf() / 1000)
@@ -46,10 +45,7 @@ const pollTransaction = async (
     txLog.callbacks?.onConfirmed?.(response)
     return {
       ...txLog,
-      tx: {
-        hash: response.hash as Hash,
-        timestamp: response.timestamp,
-      },
+      tx: response,
       status: TxStatus.success,
     }
   }