Implement PLANNING line support #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting of SCHEDULED: and DEADLINE: Keywords
heading.scheduled_date, heading.closed_date and heading.deadline_date should always be of OrgDate (or OrgDateTime) type.
according to https://orgmode.org/worg/dev/org-syntax.html#Timestamp the dayname field can be pretty much anything. And indeed in german locale setting the dayname is abbreviated with 2 letters only
also make the mappings somewhat easier to remember by having the p in front mean calendar selection and having the s in front does mean cmdline selection.
Manage the Plannings-Line CLOSING: Keyword When the TODO State changes from Done to not Done or vice versa
so the fix is, that we save a list of matches instead of a reference to the iterator
The line=None case was broken. It turns out, that it works better, if line is empty string per default.
We do test heading parsing and not date-time parsing, so these cases should be enough. Sorting should ignore inactive dates -> test added.
according to: https://orgmode.org/worg/dev/org-syntax.org.html there are only a few restrictions on the DAYNAME part. (Which is wise for other locales). So <2011-08-29 mon> is a valid date.
Allow missing day, because it is a reasonable human readable date form and we should probably brake no viable usecases with this. According to current formulation of the timestamp spec, a Date without Time is not valid anyway.
-> pt_br Locale day-names were changed to lowercase letters in this commit: https://sourceware.org/git/?p=glibc.git;a=commit;h=686db256f640372df81242bf20d458f54e069f56
|
Test failures is due to old glibc on Travis. |
The pt_BR locale had the weekday capitalization changed [1]. That means that depending on libc version (-> Travis build tests vs Fedora 29) the test either was successull or failed [2]. [1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=686db256f640372df81242bf20d458f54e069f56 [2]: commit e05f4f3 re commit e05f4f3
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 84.38% 84.38% -0.01%
==========================================
Files 49 49
Lines 6794 6902 +108
==========================================
+ Hits 5733 5824 +91
- Misses 1061 1078 +17
Continue to review full report at Codecov.
|
|
Would be nice to have this merged. |
FlorianMickler
force-pushed
the
date_parsing_tests
branch
from
2b6b90a
to
984df1a
Compare
|
@FlorianMickler thanks for working on this. I'd love to see this merged. There's a merge conflict now. Can you update your PR. @jceb any comments on this PR? this would be really helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Since I wanted to keep some statistics about closing ToDo Items I needed a mechanism to record the closing-date.
While at it i implemented the "PLANNING" Line as described here: https://orgmode.org/worg/dev/org-syntax.html#Clock,_Diary_Sexp_and_Planning
This is a revised version with fixed testing and more relaxed DATE Parsing.
Best regards,
Flo