add GetObjects for root of tree #148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgwelch
changed the title
michaelgwelch
force-pushed
the
welch/addGetObjects
branch
from
57e04e7 to
5e2c4f0
Compare
michaelgwelch
force-pushed
the
welch/fix145
branch
from
2555d90 to
e74f3a8
Compare
michaelgwelch
force-pushed
the
welch/addGetObjects
branch
3 times, most recently
from
f3f8264 to
a790ee1
Compare
michaelgwelch
force-pushed
the
welch/addGetObjects
branch
from
a790ee1 to
e513bfa
Compare
michaelgwelch
commented
Aug 29, 2024
| @@ -124,7 +125,8 @@ public int Timeout | |||
| if (Spaces != null) { Spaces.Version = version.Value; } | |||
| if (Streams != null) { Streams.Version = version.Value; } | |||
| if (Trends != null) { Trends.Version = version.Value; } | |||
| base.Version = value; | |||
| // override the base version as well | |||
| base.Version = version.Value; | |||
There was a problem hiding this comment.
make this assignment consistent with all of the others which use version.Value on the RHS. Not a big deal but I noted that line 127 which I introduced in #147 (I think) just didn't follow the pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: addGetObjects for root of tree. Returns the root object and it's direct children.