Redirect hosts only to domains with associated backends #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirect-from configuration key defines the source hostnames that should redirect to the one configured in the ingress manifest. This is not properly working with ingress that adds more hostnames in the TLS section because haproxy ingress adds all those hostnames as regular ones. Adding as a regular hostname is needed in order to make haproxy choose the right certificate in the TLS handshake. The following change is making redirect-from apply redirects only on hosts that have a backend association, which would be otherwise ending up in a 404 error anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirect-from configuration key defines the source hostnames that should redirect to the one configured in the ingress manifest. This is not properly working with ingress that adds more hostnames in the TLS section because haproxy ingress adds all those hostnames as regular ones. Adding as a regular hostname is needed in order to make haproxy choose the right certificate in the TLS handshake.
The following change is making redirect-from apply redirects only on hosts that have a backend association, which would be otherwise ending up in a 404 error anyway.