-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track muted by solo #20
Open
brummbrum
wants to merge
55
commits into
jcsteh:master
Choose a base branch
from
brummbrum:TrackMutedBySolo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brummbrum
commented
May 27, 2019
- implemented in plugin by suppressing peaks because KK firmware does not use this command at all (yet?)
- maybe some newer firmware version of KK will do so
More actions and fixes
Direct track selection in Mixer view w top row buttons
Mixer Mode Track Navigation
Direct API calls for track selection rather than Reaper actions to overcome 99 track limit
Track selection working Non existing tracks in last bank are now properly marked as not available
Bank selection
VU meter data format ok, but: - Need a better hook (update frequency) - VU meter updates not working properly. CMD_SEL_TRACK_PARAMS_CHANGED not fully understood yet
VU: - functionality is there! - some minor tweaks like scaling still open - code cleanup required
native conversion taken from Reaper SDK
- Calibration also valid for other keyboards than S Mk2?
-Meters working -Precise, non linear calibration for KK Mk2 Display Meters
Update niMidi.cpp
- Stub to isolate this pull request from fork master
efficiency improvement
- Use direct linear logarithmic conversion specifc to NI keyboard meter scaling rather than concatenating a calibration frunction after calling Reaper API standard conversions - Speed improvement - Further meter precision improvement
- linear approximation f meter between -48dB and -96dB - code simplification in peakMixerUpdate
minus96dB and code simplification
- incl editiorial changes (comments, function names, variable names) for a clearer understanding
Volume text in mixer view
Changes to tracklist update the Mixer View
includes Repeat (=Loop) button
Transport Button Lights working
- also simplified code for Volume text by using Reaper's built in conversion
Pan Marker and Callback working
- also changed some constant names to reflect their actual meaning
Volume & Pan change of selected track via 4D encoder
- still missing: Mute Solo selected track incl. light indicators
- Commands and callbacks working - Rec Arm callback working - Small fix for meters (muted & soloed is now considered)
Mute solo rec arm callbacks
- Track name changes get reflected via callback - Master track indicated in Mixer View (no mute or solo on Master) - Bank slect button light
Track names, master track, bank button lights
- implemented in plugin by supressing peaks because KK firmware does not use this command at all (yet?) - maybe some newer firmware version of KK will do so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.