Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More button lights #24

Open
wants to merge 71 commits into
base: master
Choose a base branch
from
Open

Conversation

brummbrum
Copy link
Contributor

Solo and Mute Button lights fully implemented:

  • Solo, Mute, Muted by Solo button lights for the currently selected track . Note: Solo, Mute and Muted by Solo Indicators in Mixer View were already implemented earlier
  • Undo/Redo Button lights

Leonard de Ruijter and others added 30 commits April 24, 2019 07:06
Direct track selection in Mixer view w top row buttons
Mixer Mode Track Navigation
Comments for future changes. Branch from here as this modifies architecture an multiple areas
Direct API calls for track selection rather than Reaper actions to overcome 99 track limit
Track selection working
Non existing tracks in last bank are now properly marked as not available
VU meter data format ok, but:
- Need a better hook (update frequency)
- VU meter updates not working properly. CMD_SEL_TRACK_PARAMS_CHANGED not fully understood yet
VU:
- functionality is there!
- some minor tweaks like scaling still open
- code cleanup required
native conversion taken from Reaper SDK
- Calibration also valid for other keyboards than S Mk2?
-Meters working
-Precise, non linear calibration for KK Mk2 Display Meters
- Stub to isolate this pull request from fork master
Changes to tracklist update the Mixer View
includes Repeat (=Loop) button
- also simplified code for Volume text by using Reaper's built in conversion
- also changed some constant names to reflect their actual meaning
Volume & Pan change of selected track via 4D encoder
- still missing: Mute Solo selected track incl. light indicators
- Commands and callbacks working
- Rec Arm callback working
- Small fix for meters (muted & soloed is now considered)
- Track name changes get reflected via callback
- Master track indicated in Mixer View (no mute or solo on Master)
- Bank slect button light
Track names, master track, bank button lights
- implemented in plugin by supressing peaks because KK firmware does not use this command at all (yet?)
- maybe some newer firmware version of KK will do so
Track(s) muted by solo implemented
- future roadmap
* Use extended callback function to get event driven metronome update
* Poll the metronome when project tab changes
Metronome button light via callback
Option currently implemented as const, i.e. needs to be chosen at compile time
Muted_By_Solo fixes and Generic Track Names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant