Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for heading role elements #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Skeletonxf
Copy link

This adds support for detecting and reporting on heading elements marked up as role=heading aria-level=x to the existing support for h1 - h6 elements to the headings plugin

Fixes #156

This adds support for detecting and reporting on heading elements marked up as role=heading aria-level=x to the existing support for h1 - h6 elements to the headings plugin
@khanbot
Copy link

khanbot commented Sep 22, 2019

Hey @Skeletonxf,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@Skeletonxf
Copy link
Author

[clabot:check]

@khanbot
Copy link

khanbot commented Sep 22, 2019

CLA signature looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers order does not respect role heading
2 participants