2-digit hour #235
Open
2-digit hour #235
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to use bootstrap-timepicker with Masked Input Plugin but I had no success because the hour should be return always wit two digits, otherwise cannot be validet by mask input, so the value it is canceled. All the time when the user clicks the input, the value it is reset to empty and has a strange behaviour. I did not find any settings in timepicker to force to return always 2 digits for the hour. So I decided to make changes in the code.
I this commit are the changes with a new option "hourTwoDigits" which is default set to false, to not affect the behaviour for those who already imlpemented timepicker.
$('#timepicker5').timepicker({
hourTwoDigits:true
});
|
Related to #203 |
|
Leading zero notation is used to indicate 24 hour time. It may be necessary to use a flag for |
|
Some 24-hour locales zero-pad the hour, others don't. Time libraries like Java and Moment allow you to specify. See Moment's docs: I want to allow the user to provide a localization config object which will contain the time format. This will be part of the larger i18n effort I'm currently planning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use bootstrap-timepicker with Masked Input Plugin but I had no success because the hour should be returned always with two digits, otherwise it cannot be validated by mask input, so the value it is canceled. All the time when the user clicks the input, the value it is reset to empty and has a strange behavior. I did not find any settings in the timepicker to force to return always 2 digits for the hour. So I decided to make changes in the code.
This commit contains the change, a new option "hourTwoDigits" in the settings, which is default set to false, to not affect the behavior for those who already implemented timepicker.
$('#timepicker').timepicker({
hourTwoDigits:true
});