fix(noticebar): remove blank element of left-icon (#2916)

jdf2e · Feb 4, 2024 · e12cde8 · e12cde8
1 parent a8c8c7b
commit e12cde8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/src/packages/__VUE/noticebar/index.taro.vue b/src/packages/__VUE/noticebar/index.taro.vue
@@ -12,9 +12,9 @@
       :style="barStyle"
       @click="handleClick"
     >
-      <view class="nut-noticebar__page-lefticon">
+      <view v-if="leftIcon" class="nut-noticebar__page-lefticon">
         <slot name="left-icon">
-          <Notice v-if="leftIcon" size="16px"></Notice>
+          <Notice size="16px"></Notice>
         </slot>
       </view>
       <view ref="wrap" :class="`nut-noticebar__page-wrap wrap${id}`">
@@ -94,8 +94,10 @@ import {
 import { Notice, CircleClose } from '@nutui/icons-vue-taro';
 import { createComponent, renderIcon } from '@/packages/utils/create';
 import { pxCheck } from '@/packages/utils/pxCheck';
-const { create } = createComponent('noticebar');
 import Taro from '@tarojs/taro';
+import { NoticebarDirection } from './types';
+
+const { create } = createComponent('noticebar');
 
 interface stateProps {
   wrapWidth: number;
@@ -116,9 +118,8 @@ interface stateProps {
 
 export default create({
   props: {
-    // 滚动方向  across 横向 vertical 纵向
     direction: {
-      type: String,
+      type: String as PropType<NoticebarDirection>,
       default: 'across'
     },
     list: {

diff --git a/src/packages/__VUE/noticebar/index.vue b/src/packages/__VUE/noticebar/index.vue
@@ -12,9 +12,9 @@
       :style="barStyle"
       @click="handleClick"
     >
-      <view class="nut-noticebar__page-lefticon">
+      <view v-if="leftIcon" class="nut-noticebar__page-lefticon">
         <slot name="left-icon">
-          <Notice v-if="leftIcon" size="16px"></Notice>
+          <Notice size="16px"></Notice>
         </slot>
       </view>
       <view ref="wrap" class="nut-noticebar__page-wrap">
@@ -95,6 +95,7 @@ import { createComponent } from '@/packages/utils/create';
 const { create } = createComponent('noticebar');
 import { pxCheck } from '@/packages/utils/pxCheck';
 import { PropType } from 'vue';
+import { NoticebarDirection } from './types';
 
 interface StateProps {
   wrapWidth: number;
@@ -114,9 +115,8 @@ interface StateProps {
 }
 export default create({
   props: {
-    // 滚动方向  across 横向 vertical 纵向
     direction: {
-      type: String,
+      type: String as PropType<NoticebarDirection>,
       default: 'across'
     },
     list: {

diff --git a/src/packages/__VUE/noticebar/types.ts b/src/packages/__VUE/noticebar/types.ts
@@ -0,0 +1 @@
+export type NoticebarDirection = 'across' | 'vertical';