Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): "hour-minute"类型下,修改小时不刷新分钟列的选择范围 #2784

Merged
merged 6 commits into from
Jan 5, 2024

Conversation

Robin-Wubin
Copy link
Contributor

@Robin-Wubin Robin-Wubin commented Dec 21, 2023

这个 PR 做了什么? (简要描述所做更改)
exp: datepicker在“hour-minute”类型下,minDate是10:30, maxDate是23:40,
初始时间是10:30, 那么进入选择器后,小时的范围是10-23,分钟的范围是30-59,
滑动小时数到11,期望分钟数的范围应该是0-59,
但选择器的分钟范围仍然保持初始状态:30-59,
此PR通过变更currentDate的值触发更新picker的选择范围,从而修正datepicker在变更小时数后可以更新分钟数的可选范围。

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

@eiinu eiinu added this to the v4.2.6 milestone Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e8cb423) 84.97% compared to head (27966dd) 84.95%.

Files Patch % Lines
src/packages/__VUE/datepicker/index.vue 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #2784      +/-   ##
==========================================
- Coverage   84.97%   84.95%   -0.03%     
==========================================
  Files         166      166              
  Lines       21211    21217       +6     
  Branches     2404     2404              
==========================================
  Hits        18024    18024              
- Misses       3170     3176       +6     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu modified the milestones: v4.2.6, v4.2.7 Dec 25, 2023
@eiinu eiinu merged commit 48b1aa5 into jdf2e:v4 Jan 5, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants