Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alipay, Baidu, Bilibili and Zhihu websites: #1740

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Add Alipay, Baidu, Bilibili and Zhihu websites: #1740

merged 3 commits into from
Aug 9, 2023

Conversation

tomac4t
Copy link
Contributor

@tomac4t tomac4t commented Aug 1, 2023

  • Add Alipay as medium
  • Add Baidu as medium
  • Add Bilibili as medium
  • Change QQ as medium
  • Add notes for QQ
  • Update url for QQ (The former is Wechat one, not QQ.)
  • Change Wechat as medium
  • Add notes for Wechat
  • Add Zhihu as easy
  • Add Weibo as medium
  • Add Elsevier.com as hard

Copy link
Contributor

@WebSnke WebSnke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions to your code.

_data/sites.json Outdated Show resolved Hide resolved
_data/sites.json Outdated Show resolved Hide resolved
_data/sites.json Outdated Show resolved Hide resolved
_data/sites.json Show resolved Hide resolved
_data/sites.json Show resolved Hide resolved
@WebSnke
Copy link
Contributor

WebSnke commented Aug 3, 2023

@tomac4t
It would be great if you could create separate pull requests in the future.

- Add Alipay as easy
- Add Baidu as medium
- Add Bilibili as medium
- Change QQ as easy
- Add notes for QQ
- Update url for QQ
- Change Wechat as medium
- Add notes for Wechat
- Add Zhihu as easy
- Add Weibo as medium
- Add Elsevier.com as hard
_data/sites.json Outdated Show resolved Hide resolved
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments are just to standardize the arrows we just changed, but there are a few questions there.

_data/sites.json Outdated Show resolved Hide resolved
{
"name": "Baidu",
"url": "https://passport.baidu.com/v6/cancelAccount",
"difficulty": "medium",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it medium? I feel like this needs some explanation

Copy link
Contributor Author

@tomac4t tomac4t Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just read the comments on this, I don't experience deleting its delete.

It is required to cancel every products before your delete the Baidu account. Someone said he was required to upload ID card picture but I can't verified.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

_data/sites.json Show resolved Hide resolved
_data/sites.json Outdated Show resolved Hide resolved
_data/sites.json Outdated Show resolved Hide resolved
@tupaschoal tupaschoal merged commit e682cbd into jdm-contrib:master Aug 9, 2023
4 checks passed
@tomac4t tomac4t deleted the patch-1 branch August 9, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants