Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp #226

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Revamp #226

wants to merge 19 commits into from

Conversation

fedeisas
Copy link

Hi @jdorn!

I kinda started rewriting your awesome project, introducing many changes.

I started reading the code and moving this around. I implemented PSR-4 and plan to start writing tests.

I know it's impossible that as a PR, it's really hard to review.

It's my intention to keep on adding features to it.

Some thoughts:

  • Switch from Flight to Lumen. It would be nice to have DB/Cache out of the box.
  • Inject DB and Cache into the PHPReports.
  • Unit tests and Travis for CI.
  • Maybe some code climate tool.
  • Assets concatenation/minification for production usage.
  • Key/value selects for dropdowns.
  • Sanitization of PHP Reports (maybe disallow some harmful functions).

I'm using a lot of your code, but the rewrite I'm planning is so masive that I don't know if you'd like to merge them. Also, I did not want to be rude and just copy/paste your code.

If you are interested, I'm more than happy to prepare a more solid PR for you to merge.

If not, I can start a new project with the proper attribution. 😄

Thanks!

@fedeisas
Copy link
Author

Sorry, I've forgotten to commit my src/ folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant