-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp #226
Open
fedeisas
wants to merge
19
commits into
jdorn:master
Choose a base branch
from
fedeisas:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Revamp #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, I've forgotten to commit my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jdorn!
I kinda started rewriting your awesome project, introducing many changes.
I started reading the code and moving this around. I implemented PSR-4 and plan to start writing tests.
I know it's impossible that as a PR, it's really hard to review.
It's my intention to keep on adding features to it.
Some thoughts:
I'm using a lot of your code, but the rewrite I'm planning is so masive that I don't know if you'd like to merge them. Also, I did not want to be rude and just copy/paste your code.
If you are interested, I'm more than happy to prepare a more solid PR for you to merge.
If not, I can start a new project with the proper attribution. 😄
Thanks!