feat: add tests to verify initial rendering #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roele
commented
Jan 23, 2024
roele
commented
Jan 23, 2024
jdx
reviewed
Jan 23, 2024
|
I'll leave the rest of this up to you, but I agree that the title and description shouldn't be on the same line |
jdx
approved these changes
Jan 23, 2024
jdx
reviewed
Jan 23, 2024
| @@ -133,12 +133,11 @@ impl<'a> Confirm<'a> { | |||
| let mut out = Buffer::ansi(); | |||
|
|
|||
| out.set_color(&self.theme.title)?; | |||
| write!(out, " {}", self.title)?; | |||
| writeln!(out, " {}", self.title)?; | |||
There was a problem hiding this comment.
did you want to remove the 1 column prefix?
I looked at huh and it looks like they actually put a solid line on the side which I don't really like the look of. I don't have a strong preference here, but whatever we do should be consistent across our components I think
There was a problem hiding this comment.
I guess in theory this is something that could be handled via themes if we want to go that route (not sure if huh does that or not)
There was a problem hiding this comment.
AFAIK the line on the side in huh marks the active field in a form/group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jdx Not sure how useful these could be as they only check the initial rendering but they already show 2 issues.