feat: add input validation #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roele
force-pushed
the
issues/validation
branch
from
00403f6
to
242e5c4
Compare
roele
commented
Jan 31, 2024
| self.term.move_cursor_right(self.cursor)?; | ||
|
|
||
| // if there is an error, move the cursor up from error message and right to the input | ||
| match self.err { |
There was a problem hiding this comment.
cursor handling is a nightmare. i wonder if i'm doing something wrong here but without being able to get the initial cursor position i don't see another way than working backwards from end of the output.
roele
force-pushed
the
issues/validation
branch
2 times, most recently
from
af78ad5
to
9f80ff8
Compare
roele
force-pushed
the
issues/validation
branch
from
9f80ff8
to
c2fe460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.