Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More things #52

Merged
merged 26 commits into from
May 15, 2024
Merged

More things #52

merged 26 commits into from
May 15, 2024

Conversation

Vulpesx
Copy link
Contributor

@Vulpesx Vulpesx commented May 11, 2024

Lots of commits, I'm trying not to have one huge commit :3

I have

  • fixed a typo
  • setting spinner title from run now accepts into<string>
  • list, select and multi select names being offscreen sometimes
  • fix prompts making spinner flicker
  • select and multiselect use the custom cursor for filtering now
  • select and multiselect show help when filtering
  • select and multiselect show pages when no description
  • list, select and multiselect clear the rest of the screen when changing pages, to not leave spinners all over the place
  • list, select and multiselect clear the rest of the screen when filtering, to not leave spinners all over the place

@roele
Copy link
Collaborator

roele commented May 15, 2024

It seems the List is missing a leading space for the title in the render_success method.

Screenshot 2024-05-15 at 15 02 37

IMO it's a bit weird to have this, not sure about the reason and we probably should get rid of it in all components at some point but for the time being i would align with the others.

@jdx jdx merged commit 2296464 into jdx:main May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants