Update GoogleSpeechProcessor.java #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting errors when multiple result segments come back from Google (session.transfer is called more than once). I've updated the processor to handle those but adding the metrics to the FlowFile doesn't really make sense in that context. We will have to compute aggregate metrics if we want to add them to the FlowFile. Additionally, I found the S2T works with 8000Hz sample rate. We should probably put this into the processor as a configuration setting, I've hard-coded for now to get it working.
…fixed aggregate metrics, refactored
… and data source (whether bytes or GCS URI) - and added the appropriate logic to handle that. Also changed synchronous requests to asynchronous requests to accommodate audio files over 1 minute in length. Future improvement: decide whether to create sync or async request based on audio length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting errors when multiple result segments come back from Google (session.transfer is called more than once). I've updated the processor to handle those but adding the metrics to the FlowFile doesn't really make sense in that context. We will have to compute aggregate metrics if we want to add them to the FlowFile.
Additionally, I found the S2T works with 8000Hz sample rate. We should probably put this into the processor as a configuration setting, I've hard-coded for now to get it working.