Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug Popover doesn't show when it's only rendered on visible #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Swordsman-Inaction
Copy link

The case:

render() {
  return (
    {
      this.state.visible && (
        <Popover
          isVisible={true}
          fromRect={x: 10, y: 10, width: 10, height: 10}>
            <View />
        </Popover>
      )
    }
  )
}

In this case, the Popover won't show since the props never change, and this.setState({contentSize: {}, isAwaitingShow: true}) will never be called in componentWillReceiveProps .

This PR is to fix the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant