Add tests for cleaned title

jeckman · Nov 30, 2018 · a43c352 · a43c352
1 parent 97cec53
commit a43c352
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/src/Provider/Youtube/VideoInfo.php b/src/Provider/Youtube/VideoInfo.php
@@ -361,14 +361,17 @@ public function getTitle()
      */
     public function getCleanedTitle()
     {
+        $filename = $this->getTitle();
+
         // Removes non-alphanumeric and useless character
         $special_chars = ['.', '?', '[', ']', '/', '\\', '=', '<', '>', ':', ';', ',', "'", '"', '&', '$', '#', '*', '(', ')', '|', '~', '`', '!', '{', '}', '%', '+', chr(0)];
-        $filename = str_replace($special_chars, ' ', $this->getTitle());
+        $filename = str_replace($special_chars, ' ', $filename);
 
         // Emoji is being removed
+        // FIXME: not working atm
         $filename = preg_replace("#\x{00a0}#siu", ' ', $filename);
 
-        // Litlle Housekeeping
+        // Little Housekeeping
         $filename = str_replace(['%20', '+', ' '], '-', $filename);
         $filename = preg_replace('/[\r\n\t -]+/', '-', $filename);
         $filename = trim($filename, '.-_');

diff --git a/tests/Unit/Provider/Youtube/VideoInfoTest.php b/tests/Unit/Provider/Youtube/VideoInfoTest.php
@@ -127,7 +127,20 @@ public function CleanedTitleProvider()
     {
         return [
             ['Replaces all spaces with hyphens.', 'Replaces-all-spaces-with-hyphens'],
-            ['Как делать бэкапы. Cobian Backup.', 'Как-делать-бэкапы-Cobian-Backup'], // Removes useless chars.
+            ['Как делать бэкапы. Cobian Backup.', 'Как-делать-бэкапы-Cobian-Backup'], // Keep kyril chars
+            ['测试', '测试'], // Keep chinese chars
+            ['kiểm tra', 'kiểm-tra'],
+            ['ทดสอบ', 'ทดสอบ'], // Keep korean chars
+            ['טעסטינג', 'טעסטינג'], // Keep jiddish chars
+            ['اختبارات', 'اختبارات'], // Keep arab chars
+            ['test.?[]/\\=<>:;,\'"%26$#*()|~`!{}%+chars', 'test-chars'], // %26 => &
+            ['replace%20space', 'replace-space'], // %20 => " " (space)
+            ["remove\ttabs", 'remove-tabs'],
+            ["remove\rlinebreaks", 'remove-linebreaks'],
+            ["remove\nline-breaks", 'remove-line-breaks'],
+            ["remove-\r\n-linebreaks", 'remove-linebreaks'],
+            // ['remove\xf0\x9f\x98\x80emojis', 'remove-emojis'], // not working
+            // ['remove😍emojis', 'remove-emojis'], // not working
         ];
     }