Android-build, set NDK_API_VERSION using version from ANDROID_NDK_HOME #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of forcing NDK_API_VERSION by hand to 19, use the ndk version reading the info directly from the file "${ANDROID_NDK_HOME}/source.properties"
NDK_PLATFORM will then be set accordingly
|
Hi, I'd like to avoid breaking changes and fragile parsing if possible. Why not just set Guidance can be printed if it is not found given the installed NDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got stuck in generating the libraries because of a NDK version mismatch. I made this change and it worked.
With this change, the value of NDK_API_VERSION is taken from the file "${ANDROID_NDK_HOME}/source.properties".
NDK_PLATFORM will then be set accordingly.