Re-evaluate ValueGetters if the current value is null during binding evaluation #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with a ValueGetter, the getter appears to be evaluted only once when initially converted to a TypeNode. This is unfortunately prior to any deserialized values being realised. This is a slightly hacky solution, but simply re-attempts to evaluate getters where this is the case. Signed-off-by: Bevan Weiss <[email protected]>
bevanweiss
force-pushed
the
hacky_deferred_evalution_of_getters
branch
from
a374d52
to
4a4f139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in Issue #216, when using a calculated binding, with a ValueGetter, the getter appears to be evaluted only once when initially converted to a TypeNode.
This is unfortunately prior to any deserialized values being realised.
This is a slightly hacky solution, but simply re-attempts to evaluate getters where this is the case.