Apply suggestions from code review

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
jembi · Jul 31, 2024 · 04b4e38 · 04b4e38
1 parent 449b9c1
commit 04b4e38
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/fhir-ig-importer/importer/volume/openhimConfig.js b/fhir-ig-importer/importer/volume/openhimConfig.js
@@ -46,13 +46,15 @@ const appJsonData = JSON.parse(
 //Substitute the url with environ variable
 
 let url = appJsonData.url;
+if (!process.env.OPENHIM_CONSOLE_BASE_URL) {
+  throw new Error("Environment variable OPENHIM_CONSOLE_BASE_URL is not set");
+}
 let newUrl = url.replace(
   "<openhim-console-url>",
   process.env.OPENHIM_CONSOLE_BASE_URL
 );
 
 appJsonData.url = newUrl;
-
 const data = JSON.stringify(jsonData);
 const appData = JSON.stringify(appJsonData);
 

diff --git a/kafka-mapper-consumer/openhimConfig.js b/kafka-mapper-consumer/openhimConfig.js
@@ -40,13 +40,17 @@ const appJsonData = JSON.parse(
 //Substitute the url with environ variable
 
 let url = appJsonData.url;
+
+if (!process.env.OPENHIM_CONSOLE_BASE_URL) {
+  throw new Error("Environment variable OPENHIM_CONSOLE_BASE_URL is not set");
+}
+
 let newUrl = url.replace(
   "<openhim-console-url>",
   process.env.OPENHIM_CONSOLE_BASE_URL
 );
 
 appJsonData.url = newUrl;
-
 const appData = JSON.stringify(appJsonData);
 
 const options = {

diff --git a/reprocess-mediator/openhimConfig.js b/reprocess-mediator/openhimConfig.js
@@ -40,6 +40,10 @@ const appJsonData = JSON.parse(
 //Substitute the url with environ variable
 
 let url = appJsonData.url;
+
+if (!process.env.OPENHIM_CONSOLE_BASE_URL) {
+  throw new Error("Environment variable OPENHIM_CONSOLE_BASE_URL is not set");
+}
 let newUrl = url.replace(
   "<openhim-console-url>",
   process.env.OPENHIM_CONSOLE_BASE_URL