Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default recipes #261

Merged
merged 14 commits into from
Feb 23, 2024
Merged

Add default recipes #261

merged 14 commits into from
Feb 23, 2024

Conversation

rcrichton
Copy link
Member

@rcrichton rcrichton commented Jan 10, 2024

Changes:

  • Modify release action
  • Change mapping medaitor config to allow JemPI to work with MPI mediator
  • Update Jempi package to use latest code and new Keycloak API
  • Update default config in package to create a unified example config that can be used to show how everything works together

Test using:

  • instant package init -p cdr-dw --dev
  • instant package init -p cdr --dev
  • instant package init -p mpi --dev

For more detail see docs - https://jembi.gitbook.io/openhim-platform/recipes/central-data-repository-with-data-warehousing

Correct the config to:
* use the interaction id for the resource instead of the golden id
* use a JeMPI endpoint which does matching
* return the golden ID as a refer link
The latest version has support for pushing updated patient resources to Kafka when golden IDs change for a patient in JeMPI.
* Fix SSO on mpi recipe
* Add example superset dashboard
* Add unbundler to cdr recipe for external system to read resources from Kafka
@rcrichton rcrichton marked this pull request as ready for review January 11, 2024 07:57
@rcrichton rcrichton changed the title Recipes Add default recipes Jan 12, 2024
config.yaml Outdated Show resolved Hide resolved
@rcrichton rcrichton requested a review from marrouchi January 19, 2024 09:47
@rcrichton rcrichton marked this pull request as draft January 19, 2024 11:27
@rcrichton rcrichton marked this pull request as ready for review January 19, 2024 11:27
@bradsawadye
Copy link
Contributor

@rcrichton it looks good. If we are going to merge this in, we will need to change the docker images wth the "test" tags. The endpoint for querying patients is now broken

@rcrichton
Copy link
Member Author

Thanks Brad. I need to wait for a release of JemPI for that. I think they are putting out on soon so I will hold off for that.

@bradsawadye bradsawadye marked this pull request as draft February 22, 2024 16:37
@bradsawadye bradsawadye marked this pull request as ready for review February 22, 2024 16:37
tHe logic was broken because the Boolean function that was being used, returns true for all the strings ("false" and "true"). The env variable is always a string.
@bradsawadye bradsawadye merged commit 8c80886 into main Feb 23, 2024
@bradsawadye bradsawadye deleted the recipes branch February 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants