-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tb 368 postgres package #266
Conversation
This is responsible for creating the user and database that will be used by hap-fhir TB-368
This allows us to create multiple databases by passing a string of database comma separated
The postgres database is now a separate package so the tests have to be adjusted
Remove the postgres package
Pg pool is a proxy for postgres and the postgres users have to be added to the pg pool auth interceptor
It creates tables when the table is non existant
PG pool is now used in front of postgres so the number of services expected had to be increased
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to remove the unused files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a minor comment about the docs.
Just a note on this PR to be aware of. This introduces a breaking change to already deployed instances where the database volume was created under a different name. With the re-usable postgres package being added as a deps and used for Hapi FHIR, a new volume is created, and thus all existing data in the old volume is lost |
No description provided.