Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tb 368 postgres package #266

Merged
merged 25 commits into from
Apr 23, 2024
Merged

Tb 368 postgres package #266

merged 25 commits into from
Apr 23, 2024

Conversation

bradsawadye
Copy link
Contributor

No description provided.

This is responsible for creating the user and database that will be used by hap-fhir

TB-368
This allows us to create multiple databases by passing a string of database comma separated
@bradsawadye bradsawadye marked this pull request as ready for review February 1, 2024 17:44
The postgres database is now a separate package so the tests have to be adjusted
@bradsawadye bradsawadye marked this pull request as draft February 2, 2024 06:21
@bradsawadye bradsawadye marked this pull request as ready for review February 2, 2024 06:21
@bradsawadye bradsawadye marked this pull request as draft February 2, 2024 07:24
@bradsawadye bradsawadye marked this pull request as ready for review February 2, 2024 07:24
@bradsawadye bradsawadye marked this pull request as draft February 2, 2024 08:50
@bradsawadye bradsawadye marked this pull request as ready for review February 2, 2024 08:51
@bradsawadye bradsawadye marked this pull request as draft February 2, 2024 10:19
@bradsawadye bradsawadye marked this pull request as ready for review February 2, 2024 10:20
Pg pool is a proxy for postgres and the postgres users have to be added to the pg pool auth interceptor
@bradsawadye bradsawadye marked this pull request as draft February 5, 2024 07:29
@bradsawadye bradsawadye marked this pull request as ready for review February 5, 2024 07:29
It creates tables when the table is non existant
@bradsawadye bradsawadye marked this pull request as draft February 5, 2024 10:19
@bradsawadye bradsawadye marked this pull request as ready for review February 5, 2024 10:19
@bradsawadye bradsawadye marked this pull request as draft February 5, 2024 12:20
@bradsawadye bradsawadye marked this pull request as ready for review February 5, 2024 12:20
@bradsawadye bradsawadye marked this pull request as draft February 5, 2024 16:33
@bradsawadye bradsawadye marked this pull request as ready for review February 5, 2024 16:33
PG pool is now used in front of postgres so the number of services expected had to be increased
@bradsawadye bradsawadye marked this pull request as draft February 5, 2024 18:10
@bradsawadye bradsawadye marked this pull request as ready for review February 5, 2024 18:10
Copy link
Contributor

@brett-onions brett-onions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to remove the unused files

Copy link
Member

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a minor comment about the docs.

database-postgres/README.md Show resolved Hide resolved
@bradsawadye bradsawadye dismissed rcrichton’s stale review April 23, 2024 12:06

I added the requested changes

@bradsawadye bradsawadye merged commit 9b5ff1a into main Apr 23, 2024
2 checks passed
@bradsawadye bradsawadye deleted the TB-368-postgres-package branch April 23, 2024 12:08
@BMartinos
Copy link
Collaborator

Just a note on this PR to be aware of. This introduces a breaking change to already deployed instances where the database volume was created under a different name. With the re-usable postgres package being added as a deps and used for Hapi FHIR, a new volume is created, and thus all existing data in the old volume is lost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants