-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds env variables to Reprocess Mediator + UI #315
Conversation
WalkthroughThe changes enhance the configuration and connectivity of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- config.yaml (1 hunks)
- reprocess-mediator/docker-compose.yml (2 hunks)
- reprocess-mediator/package-metadata.json (2 hunks)
Additional comments not posted (5)
reprocess-mediator/package-metadata.json (2)
7-7
: New dependency added:message-bus-kafka
.The addition of the
message-bus-kafka
dependency looks appropriate for enhancing message bus capabilities.
17-18
: New MongoDB environment variables added.The addition of
MONGODB_CONNECTION_STRING
andMONGODB_DIRECT_CONNECTION
environment variables looks appropriate for configuring MongoDB connectivity.reprocess-mediator/docker-compose.yml (2)
9-9
: New MongoDB environment variables and network added.The addition of the
MONGODB_CONNECTION_STRING
andMONGODB_DIRECT_CONNECTION
environment variables, along with theopenhim-mongo
network, looks appropriate for configuring MongoDB connectivity.Also applies to: 16-17
38-40
: New external network added:openhim_mongo_public
.The addition of the
openhim_mongo_public
external network looks appropriate for configuring MongoDB connectivity.config.yaml (1)
81-88
: Newdev
profile added.The addition of the
dev
profile with specific packages and environment files looks appropriate for development purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by CodeRabbit
New Features
dev
profile with specific packages and environment configurations.reprocess-mediator
package in thedev
profile.reprocess-mediator
.Enhancements
reprocess-mediator
dependencies to include"message-bus-kafka"
.