-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the docker info folder configurable through env variables #316
Conversation
This is to cater for the ehtipoia use case where the docker folders are stored in a different location
WalkthroughThe recent changes enhance the configurability of Docker services in the monitoring setup. By replacing hardcoded paths with environment variable references, the adjustments allow for more flexible deployment across different environments. New parameters for Docker socket and library paths were also introduced, streamlining configuration management and improving security. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- monitoring/docker-compose.cluster.yml (1 hunks)
- monitoring/docker-compose.yml (3 hunks)
- monitoring/package-metadata.json (1 hunks)
Additional comments not posted (6)
monitoring/package-metadata.json (2)
38-38
: LGTM! New environment variable for Docker socket folder.The addition of
DOCKER_SOCK_FOLDER
enhances configurability.
39-39
: LGTM! New environment variable for Docker library folder.The addition of
DOCKER_LIB_FOLDER
enhances configurability.monitoring/docker-compose.cluster.yml (1)
21-21
: LGTM! Updated volume mapping for Docker socket.The change to use
${DOCKER_SOCK_FOLDER}
enhances configurability.monitoring/docker-compose.yml (3)
78-78
: LGTM! Updated volume mapping for Prometheus service.The change to use
${DOCKER_SOCK_FOLDER}
enhances configurability.
100-100
: LGTM! Updated volume mapping for Docker library.The change to use
${DOCKER_LIB_FOLDER}
enhances configurability.
134-134
: LGTM! Updated volume mapping for promtail service.The change to use
${DOCKER_LIB_FOLDER}/containers
enhances configurability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- monitoring/docker-compose.yml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- monitoring/docker-compose.yml
This is to cater for the ehtipoia use case where the docker folders are stored in a different location
Summary by CodeRabbit
New Features
Bug Fixes