Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted the slave to master access control to github #3317

Closed
wants to merge 18 commits into from

Conversation

bigdevlarry
Copy link

Working on issue #3222 @MarkEWaite

@bigdevlarry bigdevlarry requested a review from a team as a code owner May 21, 2020 16:21
@probot-autolabeler probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label May 21, 2020
@MarkEWaite MarkEWaite linked an issue May 21, 2020 that may be closed by this pull request
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rename of the adoc will also need the entry in _chapters.yml to be renamed

Copy link
Contributor

@zbynek zbynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to eliminate links to the wiki: most of them are meant to link to the page itself and can be replaced by internal cross reference (I marked some occurences), others should link to the plugin site (see suggestions).

Also it would be good to avoid the obsolete term slave where possible: in the section titles it can be just dropped. Maybe also the whole page could be renamed to "Agent to master access control" unless @MarkEWaite can see a reason to keep the name.

content/doc/book/using/slave-master-access-control.adoc Outdated Show resolved Hide resolved
content/doc/book/using/slave-master-access-control.adoc Outdated Show resolved Hide resolved
content/doc/book/using/slave-master-access-control.adoc Outdated Show resolved Hide resolved
content/doc/book/using/slave-master-access-control.adoc Outdated Show resolved Hide resolved
content/doc/book/using/slave-master-access-control.adoc Outdated Show resolved Hide resolved
content/doc/book/using/slave-master-access-control.adoc Outdated Show resolved Hide resolved
content/doc/book/using/slave-master-access-control.adoc Outdated Show resolved Hide resolved
content/doc/book/using/slave-master-access-control.adoc Outdated Show resolved Hide resolved
content/doc/book/using/slave-master-access-control.adoc Outdated Show resolved Hide resolved
content/doc/book/using/slave-master-access-control.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the wording be changed here? The terminology is agent and is being changed wherever possible.

@MarkEWaite
Copy link
Contributor

@LarrySul on future pull requests, you'll make everyone's life easier if you perform your work on a branch which is not named "master". The "master" branch is reserved by convention (and by GitHub warning messages) to track the upstream master branch.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional items for review and consideration

@MarkEWaite
Copy link
Contributor

Closing this in favor of #3385

@MarkEWaite MarkEWaite closed this May 29, 2020
@zbynek
Copy link
Contributor

zbynek commented May 29, 2020

Replaced by #3353 ?

@bigdevlarry
Copy link
Author

@zbynek apologies for the late response, yes it was replaced with #3353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Jenkins documentation, including user and developer docs, solution pages, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert 'Slave To Master Access Control' wiki page to jenkins.io
4 participants