-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
converted the slave to master access control to github #3317
Conversation
The '?' in the asciidoc identifier for the heading did not work well.
Wiki exporter inserts multi-byte spaces that most users don't need or expect.
The source hint syntaxhighlighter-pre is not a valid source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rename of the adoc will also need the entry in _chapters.yml
to be renamed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to eliminate links to the wiki: most of them are meant to link to the page itself and can be replaced by internal cross reference (I marked some occurences), others should link to the plugin site (see suggestions).
Also it would be good to avoid the obsolete term slave where possible: in the section titles it can be just dropped. Maybe also the whole page could be renamed to "Agent to master access control" unless @MarkEWaite can see a reason to keep the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the wording be changed here? The terminology is agent and is being changed wherever possible.
@LarrySul on future pull requests, you'll make everyone's life easier if you perform your work on a branch which is not named " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional items for review and consideration
Closing this in favor of #3385 |
Replaced by #3353 ? |
Working on issue #3222 @MarkEWaite