feat: assignable downstream commits

[GavinPJK]

Adds the ability to assign a list of users to any downstream PRs generated by updatebot. Can also assign the author of the upstream commit by setting spec.rules.assignAuthorToPullRequests: true within updatebot.yaml, see pkg/cmd/pr/test_data/assignauthor/.jx/updatebot.yaml as an example.

Assumes user(s) can be assigned to downstream dependent repositories. Tested and validated with GitHub.

[jenkins-x-bot]

Hi @GavinPJK. Thanks for your PR.

I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jordangoasdoue
You can assign the PR to them by writing /assign @jordangoasdoue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[GavinPJK]

/cc @msvticket

[msvticket]

/ok-to-test

[msvticket]

The pr pipeline failed during tests:

 	WARNING: failed to find git URL no .git directory could be found from dir test_data/command
		--- FAIL: TestCreate (0.04s)
		    pr_test.go:55: excluding test assignauthor
		    pr_test.go:74: 
		        	Error Trace:	/workspace/source/pkg/cmd/pr/pr_test.go:74
		        	Error:      	Received unexpected error:
		        	            	failed to set commit details: no .git directory could be found from dir test_data/command
		        	Test:       	TestCreate
		        	Messages:   	failed to run command for test command
		FAIL
		FAIL	github.com/jenkins-x-plugins/jx-updatebot/pkg/cmd/pr	0.085s
		FAIL

[msvticket]

/test lint

[msvticket]

Please change the new methods that are only intended to be used inside the package to be private (i.e. initial letter should be lower case)

[msvticket]

Please split the commit into at least two: one with refactoring and on with the functional change.

[msvticket]

Thank you for the contribution! Please see my review comments.

[jenkins-x-bot]

@GavinPJK: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pr	99605e0	link	/test pr
lint	99605e0	link	/test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

[msvticket]

Here are the lint failures:

 	        pkg/cmd/pr/pr.go:270:45: hugeParam: rule is heavy (88 bytes); consider passing it by pointer (gocritic)
		func (o *Options) GetSparseCheckoutPatterns(rule v1alpha1.Rule) ([]string, error) {
		                                            ^
		pkg/cmd/pr/pr.go:400:31: hugeParam: rule is heavy (88 bytes); consider passing it by pointer (gocritic)
		func (o *Options) ProcessRule(rule v1alpha1.Rule, index int) error {
		                              ^
		pkg/cmd/pr/pr.go:423:35: hugeParam: rule is heavy (88 bytes); consider passing it by pointer (gocritic)
		func (o *Options) ProcessRuleURLs(rule v1alpha1.Rule, baseBranch string) error {
		                                  ^
		pkg/cmd/pr/pr.go:332:1: paramTypeCombine: func(gitURL string, sha string) (string, error) could be replaced with func(gitURL, sha string) (string, error) (gocritic)
		func (o *Options) FindCommitAuthor(gitURL string, sha string) (string, error) {
		^
		pkg/cmd/pr/pr.go:369:1: paramTypeCombine: func(dir string, commitMessage string, commitTitle string, application string) (string, error) could be replaced with func(dir, commitMessage, commitTitle, application string) (string, error) (gocritic)
		func (o *Options) SetCommitDetails(dir string, commitMessage string, commitTitle string, application string) (string, error) {
		^
		pkg/cmd/pr/pr.go:6: File is not `goimports`-ed (goimports)
			"github.com/jenkins-x/go-scm/scm"
		pkg/cmd/pr/pr_test.go:4: File is not `goimports`-ed (goimports)
			"github.com/jenkins-x/go-scm/scm"
		pkg/cmd/pr/pr.go:416:22: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
					return fmt.Errorf("Error: Failed to get sparse checkout patterns for rule #%d, error=%v\n", index, err)
					                  ^