fix(go-cli): missing build-make-build step in release

[joshuasimon-taulia]

running jx pipeline lint against the packs folder results in this message

packs/go-cli/.lighthouse/jenkins-x/release.yaml                     failed to unmarshal YAML file packs/go-cli/.lighthouse/jenkins-x/release.yaml: failed to inherit steps: failed to process uses steps: failed to resolve git URI jenkins-x/jx3-pipeline-catalog/tasks/go-cli/release.yaml@versionStream for step build-make-build: failed to : source URI jenkins-x/jx3-pipeline-catalog/tasks/go-cli/release.yaml@versionStream task from-build-pack has no step named build-make-build

the build-make-build step in the go-cli release pipeline appears to have been renamed to upload-binaries in https://github.com/jenkins-x/jx3-pipeline-catalog/pull/762/files, but the pack was never updated. @rawlingsj am i reading the intent here correctly?

maybe we should lint the pipeline files on every PR #1285
related jenkins-x-plugins/jx-pipeline#492

[jenkins-x-bot]

Hi @joshuasimon-taulia. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[joshuasimon-taulia]

/assign @ankitm123

[msvticket]

/ok-to-test
/approve

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msvticket]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jenkins-x-bot]

Valid linters:

• packs
• tasks