Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix gitlab tests flakiness #1425

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

raul-arabaolaza
Copy link
Contributor

@raul-arabaolaza raul-arabaolaza commented Nov 21, 2023

I detected most of the times flakiness was caused by a lack of resources in the Gitlab
container, as a result many API calls at random returned a 502 error code
and an HTML page asking for the user to refresh...

I have added a custom configuration to the Gitlab fixture which should help in
resource constrained environments and increased the request timeout. Also
not it uses the readiness checks instead of html web scrapping.

Also some small code changes here and there like closing the gitlab4j clients
or slighly reduce the scope of some tests.

Testing done

More than 50 local runs once I got rid of flakiness, also some runs in CloudBees proprietary builders, I also plan to have several runs on this PR builder before moving out of draft status

Submitter checklist

I detected most of the times flakiness was caused by a lack of resources in the Gitlab
container, as a result many API calls at random returned a 502 error code
and an HTML page asking for the user to refresh...

I have added a custom configuration to the Gitlab fixture which should help in
resource constrained environments and increased the request timeout. Also
not it uses the readiness checks instead of html web scrapping.

Also some small code changes here and there like closing the gitlab4j clients
or slighly reduce the scope of some tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant