“Use Default Excludes” Checkbox #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch up with remote master
…verride the previous default behavior of excluding files defined in the supporting Ant Directory Scanner library. If checked, the deployment will exclude files based on the Ant default exclude list. For the list of files patterns to exclude see https://ant.apache.org/manual/dirtasks.html#defaultexcludes
Jmcfar
approved these changes
Dec 19, 2017
|
Hi! Thanks for the contribution. Did you perform any testing as part of the changes? If so it'd be helpful to include that in the PR. Are you OK with submitting this contribution under the Apache License 2.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this changes is to address a edge case where we needed to include a ".gitignore" files as part of the deployment.
The core logic change is to call to the alternate DirScanner.Glob method setting and passing the useDefaultExcludes parameter. Additionally logic in the DataConstructor was added to set the default behavior to useDefaultExcludes = true for backwards compatibility.
To the UI, a "Use Default Excludes” checkbox was added allowing operators to control the the behavior. One anomaly exists with the new checkbox, that is for exist jobs created with previous version, the checkbox will not default to true (checked) even though it is initialized to true by the DataConstructor.
For the list of files patterns to exclude see https://ant.apache.org/manual/dirtasks.html#defaultexcludes