Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code simplification: removal of default build ARG values when factorized #418

Open
dduportal opened this issue May 17, 2023 · 2 comments
Open
Labels

Comments

@dduportal
Copy link
Contributor

While working on #417 and #409 , I wondered if we could not simplify the "spread" of build arg values to factorized locations (1 for all Linux and one for all Windows).

The goal is to avoid any leftover when updating a JDK, Git or any important component.

@team-docker-packaging I remember the constraint of having a value for build-arg in the Dockerfile because of the DockerHub automated builds (major) and allowing users to build a standalone Dockerfile without the need for additional tools (minor).

But today (May 2023):

  • We do not use the DockerHub automated build since quite some time
  • Both BuildX and Compose are part of any default Docker installation (or available as docker CLI client-side plugins easy to install for edge cases) even on Windows and Linux

Any objection for a code cleanup to remove, only when specified through a centralize file(s) , the values from Dockerfile ?

@timja
Copy link
Member

timja commented May 17, 2023

No objection to cleaning up the code

@MarkEWaite
Copy link
Contributor

No objection from me. Thanks for the idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants