chore: factorize JDK specification to docker bakefile / powershell scripts #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
force-pushed
the
chore/factorize-Dockerfile-per-JDK
branch
from
f552d08
to
e943784
Compare
dduportal
changed the title
dduportal
force-pushed
the
chore/factorize-Dockerfile-per-JDK
branch
2 times, most recently
from
ca05156
to
d81d879
Compare
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
dduportal
force-pushed
the
chore/factorize-Dockerfile-per-JDK
branch
from
d81d879
to
a255365
Compare
dduportal
added a commit
to dduportal/docker-ssh-slave
that referenced
this pull request
May 21, 2023
…#241 Signed-off-by: Damien Duportal <[email protected]>
timja
approved these changes
May 21, 2023
dduportal
added a commit
that referenced
this pull request
May 21, 2023
…s.yaml chore(updatecli) fix git-windows tracking as a follow up of #241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twin of jenkinsci/docker-agent#409
This PR merges the
Dockerfiles of the "per-JDK" folders (11/and17/).Applied the same behavior as chore: factorize JDK specification to docker bakefile (linux) / compose file (windows) docker-agent#409 and its fixups (chore(updatecli) fix JDK version tracking - fixup of #409 docker-agent#417, chore: fix Dockerfile location on the last items - fixup of #409 docker-agent#420, chore(windows) cleanup tooling and nanoserver-1809
Dockerfile- fixup of #409 docker-agent#423 and hotfix(windows) use proper tagging destination to fix publication - fixup of #409 docker-agent#425 when it applies)git-windows.yamlmanifest forupdateclito not fail the check in this PR. Added a TODO instead to fix it up once merged.Linux: JDK17 is the default (until we can do the same as described in Code simplification: removal of default build
ARGvalues when factorized docker-agent#418)Linux:
bullsseyedirectory moved to adebian/directory + added `debian tags.Windows: JDK11 is the default (ref. Add Windows JDK17 support #211 )
Windows Nanoserver: the JDK installation from Eclipse Temurin is removed in favor of a multistage, changing the default JAVA_HOME. A symbolic link is put in place to ensure it does not break compatibility (required on this PR to ensure the JAVA_HOME passed as build argument is the same everywhere)