Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore and fix SSH tests on Windows Server Core images #391

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Apr 27, 2024

While working on #388 I remembered we disabled SSH specific tests for Windows Server Core image in order to reduce tests execution time deliver a new image cf notes of #289.

This PR removes this skip and fix them by waiting 10s before trying to connect with SSH (5s wasn't enough), as discovered in #388 (comment).

Ref:

Testing done

Local tests + CI

Submitter checklist

@lemeurherve lemeurherve changed the title chore: don't skip SSH tests on Windows Server Core images chore: restore and fix SSH tests on Windows Server Core images Apr 28, 2024
@lemeurherve lemeurherve marked this pull request as ready for review April 28, 2024 00:58
@lemeurherve lemeurherve requested a review from a team as a code owner April 28, 2024 00:58
@lemeurherve lemeurherve enabled auto-merge (squash) April 28, 2024 01:26
@lemeurherve lemeurherve linked an issue Apr 28, 2024 that may be closed by this pull request
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a better check would be to try connect over ssh, retrying every x seconds in case its a bit longer or shorter but lets see how this go..

@lemeurherve lemeurherve merged commit a57e36f into jenkinsci:master Apr 28, 2024
9 checks passed
@lemeurherve lemeurherve deleted the restore-ssh-tests-for-windowsservercore branch April 29, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Windows tests
2 participants