-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: restore and fix SSH tests on Windows Server Core images #391
Merged
lemeurherve
merged 9 commits into
jenkinsci:master
from
lemeurherve:restore-ssh-tests-for-windowsservercore
Apr 28, 2024
Merged
chore: restore and fix SSH tests on Windows Server Core images #391
lemeurherve
merged 9 commits into
jenkinsci:master
from
lemeurherve:restore-ssh-tests-for-windowsservercore
Apr 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
changed the title
chore: don't skip SSH tests on Windows Server Core images
chore: restore and fix SSH tests on Windows Server Core images
Apr 28, 2024
This reverts commit 71b67f0.
This reverts commit cf8eb99.
Closed
timja
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a better check would be to try connect over ssh, retrying every x seconds in case its a bit longer or shorter but lets see how this go..
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #388 I remembered we disabled SSH specific tests for Windows Server Core image in order to
reduce tests execution timedeliver a new image cf notes of #289.This PR removes this skip and fix them by waiting 10s before trying to connect with SSH (5s wasn't enough), as discovered in #388 (comment).
Ref:
Testing done
Local tests + CI
Submitter checklist