Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct TEST_DEBUG retrieval in build.ps1 #422

Merged

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jun 9, 2024

This PR fixes a typo introduced in #396 preventing activating the debug of tests via (amongst others) an environment variable.

It also removes the duplicated declaration of the docker commands variables, lints the code by replacing double quotes around string without any variable by simple quotes so they're the same in all build.ps1 code, correctly reindents a small section of code and shortens an output log.

Extracted from:

Testing done

Local tests + CI

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lemeurherve lemeurherve force-pushed the fix-testsdebug-typo-and-lint branch from 1b560db to e1db7df Compare June 9, 2024 19:44
@lemeurherve lemeurherve changed the title fix: correct TEST_DEBUG retrieval from build.ps1 fix: correct TEST_DEBUG retrieval in build.ps1 Jun 9, 2024
@lemeurherve lemeurherve merged commit bad0642 into jenkinsci:master Jun 10, 2024
9 checks passed
@lemeurherve lemeurherve deleted the fix-testsdebug-typo-and-lint branch June 10, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants