workaround(publish.sh) Only check the last 3 Jenkins versions for publication #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
approved these changes
Jan 31, 2023
dduportal
changed the title
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #1549 introduced a new image definition: ubi-9.
Alas, our publication process is fragile and broke following this change.
This PR is a a workaround on the publication script to avoid breakage (in short term).
It only checks the past 3 Jenkins versions instead of the past 30: that should avoid the 1 hour timeout that is blocking the recent
2.389publication.In details: the script (for Linux container images) checks for the past 30 Jenkins version if they are published or not. If not, then it's rebuilt and published.
But the function in charge of checking if "pusblished" relies on the output of
make --silent show, e.g. directly from the conten t of thedocker-bake.hclfile.Since #1549 and until this PR is merged, the publication process checks for
ubi9tag for each of these 30 versions, which of coure did not exist, leading to a full (and costly) rebuild of all.Long term, we might want to propose a new delivery system: this "script" is painful, breaks often (and does not work for Windows images).
We should not try to rebuild a given tag.
PS: since the latest LTS
2.375.2was rebuilt and redeployed, we'll have to communicate to users